abdallah
/
server-env
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

server_environment_ir_config_parameter: handle empty values better

This commit is contained in:
Stéphane Bidoul (ACSONE) 2016-11-20 23:18:38 +01:00 committed by Akim Juillerat
parent 33a1917aa1
commit b35d23947d
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
server_environment_ir_config_parameter/models/ir_config_parameter.py
View File

@ -20,6 +20,10 @@ class IrConfigParameter(models.Model):
cr, uid, key, default=None, context=context) cr, uid, key, default=None, context=context)
if serv_config.has_option(SECTION, key): if serv_config.has_option(SECTION, key):
cvalue = serv_config.get(SECTION, key) cvalue = serv_config.get(SECTION, key)
if not cvalue:
raise UserError(_("Key %s is empty in "
"server_environment_file") %
(key, ))
if cvalue != value: if cvalue != value:
# we write in db on first access; # we write in db on first access;
# should we have preloaded values in database at, # should we have preloaded values in database at,

6
server_environment_ir_config_parameter/tests/test_server_environment_ircp.py
View File

@ -49,3 +49,9 @@ class TestEnv(common.SavepointCase):
res.unlink() res.unlink()
res = self.ICP.search([('key', '=', 'some.param')]) res = self.ICP.search([('key', '=', 'some.param')])
self.assertFalse(res) self.assertFalse(res)
def test_empty(self):
""" Empty config values cause error """
with self.assertRaises(UserError):
self.ICP.get_param('ircp_empty')
self.assertEqual(self.ICP.get_param('ircp_nonexistant'), False)