diff --git a/keychain/__manifest__.py b/keychain/__manifest__.py index d8ec190..ea59dec 100644 --- a/keychain/__manifest__.py +++ b/keychain/__manifest__.py @@ -3,7 +3,7 @@ { "name": "Keychain", "summary": "Store accounts and credentials", - "version": "11.0.1.0.0", + "version": "11.0.2.0.0", "category": "Uncategorized", "website": "https://akretion.com/", "author": "Akretion, Odoo Community Association (OCA)", diff --git a/keychain/models/keychain.py b/keychain/models/keychain.py index 0f1647a..bbdc109 100644 --- a/keychain/models/keychain.py +++ b/keychain/models/keychain.py @@ -61,7 +61,7 @@ class KeychainAccount(models.Model): # Only needed in v8 for _description_searchable issues return True - def get_password(self): + def _get_password(self): """Password in clear text.""" try: return self._decode_password(self.password) diff --git a/keychain/tests/test_keychain.py b/keychain/tests/test_keychain.py index ed12fd4..4e706db 100644 --- a/keychain/tests/test_keychain.py +++ b/keychain/tests/test_keychain.py @@ -67,7 +67,7 @@ class TestKeychain(TransactionCase): account.clear_password = password account._inverse_set_password() self.assertTrue(account.clear_password != account.password) - self.assertEqual(account.get_password(), password) + self.assertEqual(account._get_password(), password) def test_wrong_key(self): """It should raise an exception when encoded key != decoded.""" @@ -77,7 +77,7 @@ class TestKeychain(TransactionCase): account._inverse_set_password() config['keychain_key'] = Fernet.generate_key() try: - account.get_password() + account._get_password() self.assertTrue(False, 'It should not work with another key') except Warning as err: self.assertTrue(True, 'It should raise a Warning') @@ -133,13 +133,13 @@ class TestKeychain(TransactionCase): account.clear_password = 'abc' account._inverse_set_password() self.assertEqual( - account.get_password(), + account._get_password(), 'abc', 'Should work with dev') config['running_env'] = 'prod' with self.assertRaises(Warning): self.assertEqual( - account.get_password(), + account._get_password(), 'abc', 'Should not work with prod key') def test_multienv_blank(self): @@ -153,12 +153,12 @@ class TestKeychain(TransactionCase): account.clear_password = 'abc' account._inverse_set_password() self.assertEqual( - account.get_password(), + account._get_password(), 'abc', 'Should work with dev') config['running_env'] = 'prod' self.assertEqual( - account.get_password(), + account._get_password(), 'abc', 'Should work with prod') def test_multienv_force(self): @@ -177,12 +177,12 @@ class TestKeychain(TransactionCase): with self.assertRaises(Warning): self.assertEqual( - account.get_password(), + account._get_password(), 'abc', 'Should not work with dev') config['running_env'] = 'prod' self.assertEqual( - account.get_password(), + account._get_password(), 'abc', 'Should work with prod') def test_wrong_json(self):