diff --git a/models/ir_config_parameter.py b/models/ir_config_parameter.py index 819ef8f..14bad0c 100644 --- a/models/ir_config_parameter.py +++ b/models/ir_config_parameter.py @@ -20,6 +20,10 @@ class IrConfigParameter(models.Model): cr, uid, key, default=None, context=context) if serv_config.has_option(SECTION, key): cvalue = serv_config.get(SECTION, key) + if not cvalue: + raise UserError(_("Key %s is empty in " + "server_environment_file") % + (key, )) if cvalue != value: # we write in db on first access; # should we have preloaded values in database at, diff --git a/tests/test_server_environment_ircp.py b/tests/test_server_environment_ircp.py index 9566bb1..07fae44 100644 --- a/tests/test_server_environment_ircp.py +++ b/tests/test_server_environment_ircp.py @@ -49,3 +49,9 @@ class TestEnv(common.SavepointCase): res.unlink() res = self.ICP.search([('key', '=', 'some.param')]) self.assertFalse(res) + + def test_empty(self): + """ Empty config values cause error """ + with self.assertRaises(UserError): + self.ICP.get_param('ircp_empty') + self.assertEqual(self.ICP.get_param('ircp_nonexistant'), False)