abdallah
/
server-env
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[FIX] server_environment: default field label 

If related field is not directly set (coming from inheritance) or string
label is not specified explicitly, it might not have it in `args`,
making it generate same default field labels, causing warnings in odoo.

Before this change you could get these kind of warnings:

```
2023-09-23 13:28:39,638 1 WARNING odoodb odoo.addons.base.models.ir_model:
Two fields (field1_env_default, field2_env_default) of your.model() have
the same label:  Env Default.
```
It would generate multiple fields having same label.
This commit is contained in:
Andrius Laukavičius 2023-09-23 16:32:29 +03:00
parent d53c3842f4
commit 3cc06abfb6
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server_environment/models/server_env_mixin.py
View File

@ -401,7 +401,11 @@ class ServerEnvMixin(models.AbstractModel):
base_field_cls = base_field.__class__
field_args = base_field.args.copy() if base_field.args else {}
field_args.pop("_sequence", None)
fieldlabel = "{} {}".format(field_args.get("string", ""), "Env Default")
if hasattr(base_field, "string"):
base_label = base_field.string
else:
base_label = field_args.get("string", "")
fieldlabel = "{} {}".format(base_label, "Env Default")
field_args.update(
{
"sparse": "server_env_defaults",